Reduce cognitive complexity in 5 core functions via helper extraction - #99

--- a/app/inference.py
+++ b/app/inference.py
@@ -144,11 +144,1 @@ def run_one_task(task: Task, output_dir: str, model_names: Iterable[str]) -> boo
-def select_patch(task: Task, output_dir: str | PathLike) -> tuple[str, dict]:
-
-    patches = natsorted(list(Path(output_dir).glob("**/extracted_patch_*.diff")))
-
-    # TODO: These candidate patches must have been dismissed by reviewer. Maybe an
-    # assertion should be added to confirm this.
-    candidate_patches = [p for p in patches if may_pass_regression_tests(task, p)]
-
-    agent_comment = None
-    thread = None
-
+def _find_reviewer_approved_patch(patches: list, candidate_patches: list):

--- a/app/main.py
+++ b/app/main.py
@@ -558,0 +559,18 @@ def evaluate_swe_issue_reproducer(
+def _remove_task_output_files(task_output_dir: str, log_file_name: str) -> None:
+    """
+    Remove everything in the task output dir other than the log file and
+    some meta data files dumped by RawTask.
+    """
+    files_to_keep = [
+        log_file_name,
+        "meta.json",
+        "problem_statement.txt",
+        "developer_patch.diff",
+    ]
+    for f in Path(task_output_dir).iterdir():
+        if f.is_file() and f.name not in files_to_keep:
+            f.unlink()
+        if f.is_dir():
+            shutil.rmtree(str(f))
+
+

--- a/app/post_process.py
+++ b/app/post_process.py
@@ -217,0 +218,21 @@ def extract_diff_one_instance(
+def _apply_edits(edits, repo_path: str) -> list[int]:
+    """
+    Try to match and apply each edit. Returns indexes of edits that could not be applied.
+    """
+    unmatched_edit_indexes = []
+    for idx, edit in enumerate(edits):
+        # NOTE: do not clean here, since we want to accumulate changes from all edits
+        target_file = edit.filename
+        # find the target file. The model may only use the short name of the file,
+        # so we need to search for it here
+        found_file = apputils.find_file(repo_path, target_file)
+        if found_file is None:
+            unmatched_edit_indexes.append(idx)
+            continue
+        # try to apply this edit and update the actual file content
+        applied_file = apply_edit(edit, found_file)
+        if applied_file is None:
+            unmatched_edit_indexes.append(idx)
+    return unmatched_edit_indexes
+
+

--- a/app/search/search_backend.py
+++ b/app/search/search_backend.py
@@ -773,11 +773,3 @@ class SearchBackend:
-        if not tmp_class_name and tmp_method_name and "." in tmp_method_name:
-            fragments = tmp_method_name.split(".")
-            if len(fragments) == 2:
-                tmp_class_name, tmp_method_name = fragments
-                logger.warning(
-                    "Successfully split {} and {}", tmp_class_name, tmp_method_name
-                )
-            else:
-                logger.warning(
-                    "Too many fragments. Examine the method name: {}", tmp_method_name
-                )
+        tmp_class_name, tmp_method_name = self._split_class_method_name(
+            tmp_class_name, tmp_method_name
+        )

--- a/app/search/search_manage.py
+++ b/app/search/search_manage.py
@@ -98,13 +98,1 @@ class SearchManager:
-            formatted = []
-            if json_api_calls:
-                formatted.append("API calls:")
-                for call in json_api_calls:
-                    formatted.extend([f"\n- `{call}`"])
-
-            if buggy_locations:
-                formatted.append("\n\nBug locations")
-                for location in buggy_locations:
-                    s = ", ".join(f"{k}: `{v}`" for k, v in location.items())
-                    formatted.extend([f"\n- {s}"])
-
-            print_acr("\n".join(formatted), "Agent-selected API calls")
+            self._print_selected_apis(json_api_calls, buggy_locations)